07_tempConversion: Update tempConversion function's naming #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
thatblindgeye
approved these changes
Nov 19, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
This looks good! Thanks for making this update. Im just going to add the Do Not Merge label until your other PR is ready to be merged.
thatblindgeye
added
Status: Do Not Merge
aegis945
pushed a commit
to aegis945/javascript-exercises
that referenced
this pull request
Jan 15, 2023
07_tempConversion: Update tempConversion function's naming
Oussama5379
added a commit
to Oussama5379/javascript-exercises
that referenced
this pull request
Feb 1, 2025
07_tempConversion: Update tempConversion function's naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The current function names in tempConversion are unreadable and directly contradict eveything stated about writing clean code two lesson earlier this PR updates them to be more inline
This PR
Related to
Additional Information
Discussed in https://discord.com/channels/505093832157691914/1041022385123491840. While there was some valid reasoning that the convention we lay forth in the clean code isn't always used nor always the standard convention, I saw no real opposition to the specific issue of updating these names.
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRsolutionsbranch, I have created another PR (and linked it to this PR).