Skip to content

Conversation

@rlmoser99
Copy link
Member

Because:
If the details are first, they are viewable in Discord's webhook.

This PR:

  • Moves the detail sections to the beginning of the template
  • Moves the checklist section to the end of the template
  • Adds an issue section to link the issue
  • Adds the Because, This PR, and Issue sections to checklist
  • Reduce wording that is not essential

Related to TheOdinProject/curriculum#24779

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

  • I have ensured any exercise files included in this PR have passed all of their tests

Because:
If the details are first, they are viewable in Discord's webhook.

This PR:
* Moves the detail sections to the beginning of the template
* Moves the checklist section to the end of the template
* Adds an issue section to link the issue
* Adds the Because, This PR, and Issue sections to checklist
* Reduce wording that is not essential
@rlmoser99 rlmoser99 merged commit a05d4d6 into main Oct 22, 2022
@rlmoser99 rlmoser99 deleted the simplify-pr-template branch October 22, 2022 02:43
flealc pushed a commit to flealc/javascript-exercises that referenced this pull request Nov 11, 2022
* PR Template: Flip order of checklist and details

Because:
If the details are first, they are viewable in Discord's webhook.

This PR:
* Moves the detail sections to the beginning of the template
* Moves the checklist section to the end of the template
* Adds an issue section to link the issue
* Adds the Because, This PR, and Issue sections to checklist
* Reduce wording that is not essential
aegis945 pushed a commit to aegis945/javascript-exercises that referenced this pull request Jan 15, 2023
* PR Template: Flip order of checklist and details

Because:
If the details are first, they are viewable in Discord's webhook.

This PR:
* Moves the detail sections to the beginning of the template
* Moves the checklist section to the end of the template
* Adds an issue section to link the issue
* Adds the Because, This PR, and Issue sections to checklist
* Reduce wording that is not essential
Oussama5379 added a commit to Oussama5379/javascript-exercises that referenced this pull request Feb 1, 2025
* PR Template: Flip order of checklist and details

Because:
If the details are first, they are viewable in Discord's webhook.

This PR:
* Moves the detail sections to the beginning of the template
* Moves the checklist section to the end of the template
* Adds an issue section to link the issue
* Adds the Because, This PR, and Issue sections to checklist
* Reduce wording that is not essential
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants