Skip to content

Conversation

@abhijitgawai
Copy link

Describe your change:

1st :-
Added Base Condition to Reduce Time Complexity

2nd :-
Previously Time Complexity was O( max( len(first_str) , len(second_str) ) )
So, now on line 26, I am considering minimum length of both string.
Select alternate characters of both strings. For max( len(first_str) , len(second_str) ) times and exit for loop
Then Concatenate remaining characters of larger string. <- This does not require for loop, Thus reducing Time Complexity.

Now Time Complexity is O( min ( len(first_str) , len(second_str) ) )

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 11, 2021
Comment on lines +18 to +21
if len(first_str)==0:
return second_str
if len(second_str)==0:
return first_str
Copy link
Member

@cclauss cclauss Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if len(first_str)==0:
return second_str
if len(second_str)==0:
return first_str
if not first_str or not second_str:
return first_str and second_str

@cclauss cclauss closed this Oct 11, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2021
@abhijitgawai abhijitgawai mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants