Skip to content

Conversation

mrvnmchm
Copy link
Member

@mrvnmchm mrvnmchm commented Aug 7, 2019

Added pytests to digital_image_processing. Also, potential typo found in digital_image_processing/filters/median_filter.py line 18

Found typo during testing.
image

Error resolved after fix
image

@mrvnmchm mrvnmchm mentioned this pull request Aug 7, 2019
10 tasks
@cclauss
Copy link
Member

cclauss commented Aug 7, 2019

Our automated testing new rejects unused imports
https://travis-ci.org/TheAlgorithms/Python/jobs/568869592#L565

@cclauss
Copy link
Member

cclauss commented Aug 7, 2019

Still 9 things imported but not used.
https://travis-ci.org/TheAlgorithms/Python/jobs/568979496#L565

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this PR attempt to change files outside of digital_image_processing?
https://travis-ci.org/TheAlgorithms/Python/jobs/569120280#L567

@mrvnmchm
Copy link
Member Author

mrvnmchm commented Aug 8, 2019

Looks like the previous fork had some outdated information. Ended up deleting and re-forking to remove error. New fork, added these changes, submitting new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants