-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Added Germain primes algorithm to the maths folder #10120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4117826
Added algorithm for Germain Primes to maths folder
meganpayneconsulting f8df92d
Fixed test errors Germain primes.
meganpayneconsulting 5a651e8
Formatting Germain primes after pre-commit
meganpayneconsulting d3786fd
Fixed path to maths
meganpayneconsulting b01463c
Update maths/germain_primes.py
megpay eb6a6fd
Update maths/germain_primes.py
megpay 88583ec
Merge branch 'TheAlgorithms:master' into master
megpay a082e47
Added function for safe primes
meganpayneconsulting 7c7d824
Update maths/germain_primes.py
megpay 0257507
Apply suggestions from code review
tianyizheng02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
""" | ||
A Germain prime is any prime p, where 2p + 1 is also prime. | ||
The second number, 2p + 1 is called a safe prime. | ||
megpay marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Examples of Germain primes include: 2, 3, 5, 11, 23 | ||
|
||
Their corresponding safe primes: 5, 7, 11, 23, 47 | ||
https://en.wikipedia.org/wiki/Safe_and_Sophie_Germain_primes | ||
""" | ||
|
||
from maths.prime_check import is_prime | ||
|
||
|
||
def is_germain_prime(number: int) -> bool: | ||
"""Checks if input number and 2*number + 1 are prime. | ||
|
||
>>> is_germain_prime(3) | ||
True | ||
>>> is_germain_prime(11) | ||
True | ||
>>> is_germain_prime(4) | ||
False | ||
>>> is_germain_prime(23) | ||
True | ||
>>> is_germain_prime(13) | ||
False | ||
>>> is_germain_prime(20) | ||
False | ||
>>> is_germain_prime('abc') | ||
Traceback (most recent call last): | ||
... | ||
TypeError: Input value must be a positive integer. Input value: abc | ||
""" | ||
if not isinstance(number, int) or not number >= 1: | ||
megpay marked this conversation as resolved.
Show resolved
Hide resolved
|
||
msg = f"Input value must be a positive integer. Input value: {number}" | ||
raise TypeError(msg) | ||
|
||
if is_prime(number) and is_prime(2 * number + 1): | ||
return True | ||
return False | ||
megpay marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
if __name__ == "__main__": | ||
from doctest import testmod | ||
|
||
testmod() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.