-
Notifications
You must be signed in to change notification settings - Fork 1
Update to AwesomeAssertions/.NET9 #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Ah, I'll look into the style convention of the PR message as well as commit messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was an active contributor to Fluentassertions, but with their license changes abandoned the project (I am now using aweXpect instead).
So I also won't update this extension to Fluentassertions any longer. If you want, you can take it over and make it an extension for AwesomeAssertions, but maybe it would make more sense to move it there and rename it to e.g. AwesomeAssertions.Testably.Abstractions?
| <ItemGroup> | ||
| <PackageReference Include="AwesomeAssertions" /> | ||
| <PackageReference Include="Testably.Abstractions.Testing" /> | ||
| <PackageReference Remove="AwesomeAssertions" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not need to add and remove AwesomeAssertions in the test project
Hi!
I recently discovered your awesome testing libraries.
While trying the FluentAssertions nuget package, I couldn't compile them with Testably.Abstractions.
It seems to have a dependency on TestableIO.Abstractions, which break if said package isn't installed.
When I cloned the repo and added the project directly, everything worked as expected :)
However, instead of just asking for an update of the package, I tried updating/migrating it to the latest AwesomeAssertions version. I took the liberty to rename the project to AwesomeAssertions, since many other projects did the same.
Please take a look at my changes. The test suite ran successfully, though I'm not sure if my changes are to your standards (and if I did the migration to AssertionChain correctly).
Thank you for your effort!