feat: Add an explicit cast operator for FileSystemStream #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an explicit cast to change the fact, that the underlaying FileStream could not be accessed in any way. This has also the advantage that if the library is updated no code change is necessary if a cast was present from a stream.
Birnsen
changed the title
fgreinacher
approved these changes
Jan 31, 2023
Contributor
fgreinacher
left a comment
fgreinacher
left a comment
There was a problem hiding this comment.
Helpful little addition, thanks!
vbreuss
referenced
this pull request
in Testably/Testably.Abstractions
Feb 13, 2023
…19.1.14 (#239) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.1.1` -> `19.1.14` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.1.14`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.14) ##### What's Changed - feat: Add an explicit cast operator for FileSystemStream by [@​Birnsen](https://togithub.com/Birnsen) in [https://github.com/TestableIO/System.IO.Abstractions/pull/940](https://togithub.com/TestableIO/System.IO.Abstractions/pull/940) ##### New Contributors - [@​Birnsen](https://togithub.com/Birnsen) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/940](https://togithub.com/TestableIO/System.IO.Abstractions/pull/940) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.1.13...v19.1.14 ### [`v19.1.13`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.13) ##### What's Changed - chore(deps): update dependency benchmarkdotnet to v0.13.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/928](https://togithub.com/TestableIO/System.IO.Abstractions/pull/928) - chore(deps): update dependency moq to v4.18.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/930](https://togithub.com/TestableIO/System.IO.Abstractions/pull/930) - docs: mention related projects by [@​fgreinacher](https://togithub.com/fgreinacher) in [https://github.com/TestableIO/System.IO.Abstractions/pull/931](https://togithub.com/TestableIO/System.IO.Abstractions/pull/931) - chore(deps): update dependency dotnet-sdk to v7.0.102 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/932](https://togithub.com/TestableIO/System.IO.Abstractions/pull/932) - chore(deps): update dependency benchmarkdotnet to v0.13.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/933](https://togithub.com/TestableIO/System.IO.Abstractions/pull/933) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.14 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/934](https://togithub.com/TestableIO/System.IO.Abstractions/pull/934) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.15 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/936](https://togithub.com/TestableIO/System.IO.Abstractions/pull/936) - feat: implement MockFile.ReadLinesAsync by [@​patricksadowski](https://togithub.com/patricksadowski) in [https://github.com/TestableIO/System.IO.Abstractions/pull/935](https://togithub.com/TestableIO/System.IO.Abstractions/pull/935) ##### New Contributors - [@​patricksadowski](https://togithub.com/patricksadowski) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/935](https://togithub.com/TestableIO/System.IO.Abstractions/pull/935) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.1.5...v19.1.13 ### [`v19.1.5`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.5) #### What's Changed - chore(deps): update dependency dotnet-sdk to v7.0.101 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/924](https://togithub.com/TestableIO/System.IO.Abstractions/pull/924) - chore(deps): update dependency microsoft.net.test.sdk to v17.4.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/925](https://togithub.com/TestableIO/System.IO.Abstractions/pull/925) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.13 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/926](https://togithub.com/TestableIO/System.IO.Abstractions/pull/926) - fix: Fixing UNC path GetFullPath when Current Directory is a UNC path by [@​michal-ciechan](https://togithub.com/michal-ciechan) in [https://github.com/TestableIO/System.IO.Abstractions/pull/887](https://togithub.com/TestableIO/System.IO.Abstractions/pull/887) #### New Contributors - [@​michal-ciechan](https://togithub.com/michal-ciechan) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/887](https://togithub.com/TestableIO/System.IO.Abstractions/pull/887) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.1.1...v19.1.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzAuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEzMC4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
This is addressed in release v19.1.14. |
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an explicit cast to change the fact, that the underlaying FileStream can not be accessed in any way.
This has also the advantage that if the library is updated no code change is necessary if a cast was present from a stream.