refactor: extract ACL related functionality

src/System.IO.Abstractions.TestingHelpers/FileSystemExtensibility.cs

@@ -0,0 +1,77 @@
+using System.Collections.Generic;
+
+namespace System.IO.Abstractions.TestingHelpers
+{
+    internal class FileSystemExtensibility : IFileSystemExtensibility
+    {
+        private readonly Dictionary<string, object> _metadata = new();
+
+        /// <inheritdoc cref="IFileSystemExtensibility.TryGetWrappedInstance{T}(out T)" />
+        public bool TryGetWrappedInstance<T>(out T wrappedInstance)
+        {
+            wrappedInstance = default;
+            return false;
+        }
+
+        /// <inheritdoc cref="IFileSystemExtensibility.StoreMetadata{T}(string, T)" />
+        public void StoreMetadata<T>(string key, T value)
+        {
+            _metadata[key] = value;
+        }
+
+        /// <inheritdoc cref="IFileSystemExtensibility.RetrieveMetadata{T}(string)" />
+        public T RetrieveMetadata<T>(string key)
+        {
+            if (_metadata.TryGetValue(key, out object value) &&
+                value is T castedValue)
+            {
+                return castedValue;
+            }
+
+            return default;
+        }
+
+        internal void Clone(FileSystemExtensibility template)
+        {
+            foreach (var item in template._metadata)
+            {
+                _metadata[item.Key] = item.Value;
+            }
+        }
+
+        public static IFileSystemExtensibility GetNullObject(Func<Exception> exceptionFactory)
+            => new NullFileSystemExtensibility(exceptionFactory);
+
+        private class NullFileSystemExtensibility : IFileSystemExtensibility
+        {
+            private readonly Func<Exception> _exceptionFactory;
+
+            public NullFileSystemExtensibility(Func<Exception> exceptionFactory)
+            {
+                _exceptionFactory = exceptionFactory;
+            }
+
+            /// <inheritdoc cref="IFileSystemExtensibility.TryGetWrappedInstance{T}(out T)" />
+            public bool TryGetWrappedInstance<T>(out T wrappedInstance)
+            {
+                wrappedInstance = default;
+                return false;
+            }
+
+            /// <inheritdoc cref="IFileSystemExtensibility.StoreMetadata{T}(string, T)" />
+            public void StoreMetadata<T>(string key, T value)
+            {
+                _ = key;
+                _ = value;
+                throw _exceptionFactory.Invoke();
+            }
+
+            /// <inheritdoc cref="IFileSystemExtensibility.RetrieveMetadata{T}(string)" />
+            public T RetrieveMetadata<T>(string key)
+            {
+                _ = key;
+                throw _exceptionFactory.Invoke();
+            }
+        }
+    }
+}

src/System.IO.Abstractions.TestingHelpers/MockDirectory.cs

@@ -1,9 +1,6 @@
 using System.Collections.Generic;
-using System.ComponentModel;
 using System.Globalization;
 using System.Linq;
-using System.Runtime.Versioning;
-using System.Security.AccessControl;
 using System.Text.RegularExpressions;
 
 namespace System.IO.Abstractions.TestingHelpers
@@ -39,17 +36,10 @@ public MockDirectory(IMockFileDataAccessor mockFileDataAccessor, string currentD
         /// <inheritdoc />
         public override IDirectoryInfo CreateDirectory(string path)
         {
-            return CreateDirectoryInternal(path, null);
+            return CreateDirectoryInternal(path);
         }
 
-
-        /// <inheritdoc />
-        public override IDirectoryInfo CreateDirectory(string path, DirectorySecurity directorySecurity)
-        {
-            return CreateDirectoryInternal(path, directorySecurity);
-        }
-
-        private IDirectoryInfo CreateDirectoryInternal(string path, DirectorySecurity directorySecurity)
+        private IDirectoryInfo CreateDirectoryInternal(string path)
         {
             if (path == null)
             {
@@ -80,11 +70,6 @@ private IDirectoryInfo CreateDirectoryInternal(string path, DirectorySecurity di
 
             var created = new MockDirectoryInfo(mockFileDataAccessor, path);
 
-            if (directorySecurity != null)
-            {
-                created.SetAccessControl(directorySecurity);
-            }
-
             return created;
         }
 
@@ -173,31 +158,6 @@ public override bool Exists(string path)
         }
 
 
-        /// <inheritdoc />
-        [SupportedOSPlatform("windows")]
-        public override DirectorySecurity GetAccessControl(string path)
-        {
-            mockFileDataAccessor.PathVerifier.IsLegalAbsoluteOrRelative(path, "path");
-            path = path.TrimSlashes();
-
-            if (!mockFileDataAccessor.Directory.Exists(path))
-            {
-                throw CommonExceptions.CouldNotFindPartOfPath(path);
-            }
-
-            var directoryData = (MockDirectoryData)mockFileDataAccessor.GetFile(path);
-            return directoryData.AccessControl;
-        }
-
-
-        /// <inheritdoc />
-        [SupportedOSPlatform("windows")]
-        public override DirectorySecurity GetAccessControl(string path, AccessControlSections includeSections)
-        {
-            return GetAccessControl(path);
-        }
-
-
         /// <inheritdoc />
         public override DateTime GetCreationTime(string path)
         {
@@ -559,22 +519,6 @@ public override IFileSystemInfo ResolveLinkTarget(string linkPath, bool returnFi
 
 #endif
 
-        /// <inheritdoc />
-        [SupportedOSPlatform("windows")]
-        public override void SetAccessControl(string path, DirectorySecurity directorySecurity)
-        {
-            mockFileDataAccessor.PathVerifier.IsLegalAbsoluteOrRelative(path, "path");
-            path = path.TrimSlashes();
-
-            if (!mockFileDataAccessor.Directory.Exists(path))
-            {
-                throw CommonExceptions.CouldNotFindPartOfPath(path);
-            }
-
-            var directoryData = (MockDirectoryData)mockFileDataAccessor.GetFile(path);
-            directoryData.AccessControl = directorySecurity;
-        }
-
         /// <inheritdoc />
         public override void SetCreationTime(string path, DateTime creationTime)
         {

src/System.IO.Abstractions.TestingHelpers/MockDirectoryData.cs

@@ -7,10 +7,6 @@ namespace System.IO.Abstractions.TestingHelpers
     [Serializable]
     public class MockDirectoryData : MockFileData
     {
-
-        [NonSerialized]
-        private DirectorySecurity accessControl;
-
         /// <inheritdoc />
         public MockDirectoryData() : base(string.Empty)
         {
@@ -25,9 +21,16 @@ public MockDirectoryData() : base(string.Empty)
             {
                 // DirectorySecurity's constructor will throw PlatformNotSupportedException on non-Windows platform, so we initialize it in lazy way.
                 // This let's us use this class as long as we don't use AccessControl property.
-                return accessControl ?? (accessControl = new DirectorySecurity());
+                var directorySecurity = Extensibility.RetrieveMetadata<DirectorySecurity>("AccessControl:DirectorySecurity");
+                if (directorySecurity == null)
+                {
+                    directorySecurity = new DirectorySecurity();
+                    Extensibility.StoreMetadata("AccessControl:DirectorySecurity", directorySecurity);
+                }
+
+                return directorySecurity;
             }
-            set { accessControl = value; }
+            set { Extensibility.StoreMetadata("AccessControl:DirectorySecurity", value); }
         }
     }
 }

src/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs

@@ -26,6 +26,15 @@ public MockDirectoryInfo(IMockFileDataAccessor mockFileDataAccessor, string dire
         {
             this.mockFileDataAccessor = mockFileDataAccessor ?? throw new ArgumentNullException(nameof(mockFileDataAccessor));
 
+            if (directoryPath== null)
+            {
+                throw new ArgumentNullException("path", StringResources.Manager.GetString("VALUE_CANNOT_BE_NULL"));
+            }
+            if (directoryPath.Trim() == string.Empty)
+            {
+                throw CommonExceptions.PathIsNotOfALegalForm("path");
+            }
+
             originalPath = directoryPath;
             directoryPath = mockFileDataAccessor.Path.GetFullPath(directoryPath);
 
@@ -98,6 +107,17 @@ public override bool Exists
             }
         }
 
+        /// <inheritdoc />
+        public override IFileSystemExtensibility Extensibility
+        {
+            get
+            {
+                var mockFileData = mockFileDataAccessor.GetFile(directoryPath);
+                return mockFileData?.Extensibility ?? FileSystemExtensibility.GetNullObject(
+                    () => CommonExceptions.CouldNotFindPartOfPath(directoryPath));
+            }
+        }
+
         /// <inheritdoc />
         public override string Extension
         {
@@ -179,14 +199,7 @@ public override void Create()
             mockFileDataAccessor.Directory.CreateDirectory(FullName);
             refreshOnNextRead = true;
         }
-
-        /// <inheritdoc />
-        public override void Create(DirectorySecurity directorySecurity)
-        {
-            mockFileDataAccessor.Directory.CreateDirectory(FullName, directorySecurity);
-            refreshOnNextRead = true;
-        }
-
+
         /// <inheritdoc />
         public override IDirectoryInfo CreateSubdirectory(string path)
         {
@@ -277,19 +290,7 @@ public override IEnumerable<IFileSystemInfo> EnumerateFileSystemInfos(string sea
             return GetFileSystemInfos(searchPattern, enumerationOptions);
         }
 #endif
-
-        /// <inheritdoc />
-        public override DirectorySecurity GetAccessControl()
-        {
-            return mockFileDataAccessor.Directory.GetAccessControl(directoryPath);
-        }
-
-        /// <inheritdoc />
-        public override DirectorySecurity GetAccessControl(AccessControlSections includeSections)
-        {
-            return mockFileDataAccessor.Directory.GetAccessControl(directoryPath, includeSections);
-        }
-
+
         /// <inheritdoc />
         public override IDirectoryInfo[] GetDirectories()
         {
@@ -388,13 +389,7 @@ public override void MoveTo(string destDirName)
         {
             mockFileDataAccessor.Directory.Move(directoryPath, destDirName);
         }
-
-        /// <inheritdoc />
-        public override void SetAccessControl(DirectorySecurity directorySecurity)
-        {
-            mockFileDataAccessor.Directory.SetAccessControl(directoryPath, directorySecurity);
-        }
-
+
         /// <inheritdoc />
         public override IDirectoryInfo Parent
         {

src/System.IO.Abstractions.TestingHelpers/MockFile.cs

@@ -1,8 +1,6 @@
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
-using System.Runtime.Versioning;
-using System.Security.AccessControl;
 using System.Text;
 
 namespace System.IO.Abstractions.TestingHelpers
@@ -268,28 +266,6 @@ public override bool Exists(string path)
             return false;
         }
 
-        /// <inheritdoc />
-        [SupportedOSPlatform("windows")]
-        public override FileSecurity GetAccessControl(string path)
-        {
-            mockFileDataAccessor.PathVerifier.IsLegalAbsoluteOrRelative(path, "path");
-
-            if (!mockFileDataAccessor.FileExists(path))
-            {
-                throw CommonExceptions.FileNotFound(path);
-            }
-
-            var fileData = mockFileDataAccessor.GetFile(path);
-            return fileData.AccessControl;
-        }
-
-        /// <inheritdoc />
-        [SupportedOSPlatform("windows")]
-        public override FileSecurity GetAccessControl(string path, AccessControlSections includeSections)
-        {
-            return GetAccessControl(path);
-        }
-
         /// <summary>
         /// Gets the <see cref="FileAttributes"/> of the file on the path.
         /// </summary>
@@ -732,22 +708,6 @@ public override IFileSystemInfo ResolveLinkTarget(string linkPath, bool returnFi
         }
 #endif
 
-        /// <inheritdoc />
-        [SupportedOSPlatform("windows")]
-        public override void SetAccessControl(string path, FileSecurity fileSecurity)
-        {
-            mockFileDataAccessor.PathVerifier.IsLegalAbsoluteOrRelative(path, "path");
-
-            if (!mockFileDataAccessor.FileExists(path))
-            {
-                throw CommonExceptions.FileNotFound(path);
-            }
-
-            var fileData = mockFileDataAccessor.GetFile(path);
-            mockFileDataAccessor.AdjustTimes(fileData, TimeAdjustments.LastAccessTime);
-            fileData.AccessControl = fileSecurity;
-        }
-
         /// <inheritdoc />
         public override void SetAttributes(string path, FileAttributes fileAttributes)
         {