-
Notifications
You must be signed in to change notification settings - Fork 5
feat: support arm platforms and custom binaries #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kaycebasques
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed fix for label passing.
Now that label passing has been fixed I think I have run into a different issue. Will investigate and leave another review.
Co-authored-by: Kayce Basques <[email protected]>
kaycebasques
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the two suggestions I just left will fix the latest MODULE.bazel.lock issues I encountered
kaycebasques
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a mac intel arch flag
🤞 after 103 attempts (lol) it seems like I'm close to having all of our 60+ CI/CQ tryjobs passing https://pwrev.dev/247192
kaycebasques
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hallelujah, all CI/CQ tryjobs passed
all good on my end to merge!! what a journey lol thank you for your patience @TendTo
|
That's very good to hear. And thank you for the support. I didn't have the necessary knowledge (and motivation) to do it on my own. Now the tool is more useful. |
|
Yes I'm very satisfied that we have successfully worked towards a true general-purpose solution that has been robustly tested against a big/complex project! Thanks again for all your time & energy here |
Added
mac-siliconto support the Apple silicon macs [ closes Support Arm Mac #8 ]doxygenextension rule [ closes Support Arm Mac #8 ]Changed
versiontoconfigurationBREAKING CHANGE