Skip to content

Conversation

@TendTo
Copy link
Owner

@TendTo TendTo commented Nov 24, 2024

Added

Changed

  • Module extension tag renamed from version to configuration BREAKING CHANGE

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed fix for label passing.

Now that label passing has been fixed I think I have run into a different issue. Will investigate and leave another review.

@TendTo TendTo requested a review from kaycebasques November 27, 2024 00:47
Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two suggestions I just left will fix the latest MODULE.bazel.lock issues I encountered

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a mac intel arch flag

🤞 after 103 attempts (lol) it seems like I'm close to having all of our 60+ CI/CQ tryjobs passing https://pwrev.dev/247192

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hallelujah, all CI/CQ tryjobs passed

all good on my end to merge!! what a journey lol thank you for your patience @TendTo

@TendTo
Copy link
Owner Author

TendTo commented Nov 27, 2024

That's very good to hear. And thank you for the support. I didn't have the necessary knowledge (and motivation) to do it on my own. Now the tool is more useful.
When the people from Doxygen release the arm binaries, I will update the default download.

@TendTo TendTo merged commit 4b3b411 into main Nov 27, 2024
48 checks passed
@TendTo TendTo deleted the feat/support-arm-binaries branch November 27, 2024 17:52
@kaycebasques
Copy link
Contributor

Yes I'm very satisfied that we have successfully worked towards a true general-purpose solution that has been robustly tested against a big/complex project! Thanks again for all your time & energy here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Arm Mac

4 participants