feat: support OUTDIR in Doxyfile #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
to pigweed-project/pigweed
that referenced
this pull request
Aug 5, 2025
This is a reland of commit ed98e92 https://pwrev.dev/299993 was reverted because the local macOS ARM docs build was failing. As of https://pwrev.dev/309760 that tryjob coverage gap is now filled. The root issue was the hardcoded tagfile path in //docs/doxygen/Doxyfile that change #299993 introduced. This hardcoded path is invalid on macOS ARM. The new OUTDIR feature introduced in TendTo/rules_doxygen#30 lets us configure this path properly for all host OSes. Bug: 434937497 Original change's description: > docs: Enable Doxylink > > Doxylink is a lightweight Sphinx extension that makes it easy > to link from the main pigweed.dev site (powered by Sphinx) > to the pigweed.dev/doxygen subsite (powered by Doxygen). > > Bug: 426012010 > > Change-Id: I49c6c66a8bbb45dc05a47df0e526a5d5acf5a5a3 > Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/299993 > Pigweed-Auto-Submit: Kayce Basques <[email protected]> > Tests-Not-Needed: Kayce Basques <[email protected]> > Copybara-Verified: Copybara Prod <[email protected]> > Commit-Queue: Kayce Basques <[email protected]> > Lint: Lint 🤖 <[email protected]> > Reviewed-by: Armando Montanez <[email protected]> Bug: 426012010 Change-Id: I29d86266c5ffe1279610da89d34565b053ccf2b9 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/309434 Presubmit-Verified: CQ Bot Account <[email protected]> Commit-Queue: Kayce Basques <[email protected]> Tests-Not-Needed: Kayce Basques <[email protected]> Reviewed-by: Alexei Frolov <[email protected]> Lint: Lint 🤖 <[email protected]>
TheBlindArchitect
pushed a commit
to XSLabs/fuchsia
that referenced
this pull request
Aug 5, 2025
This is a reland of commit ed98e925da046f4ecfe802e890efb0258253f256 https://pwrev.dev/299993 was reverted because the local macOS ARM docs build was failing. As of https://pwrev.dev/309760 that tryjob coverage gap is now filled. The root issue was the hardcoded tagfile path in //docs/doxygen/Doxyfile that change #299993 introduced. This hardcoded path is invalid on macOS ARM. The new OUTDIR feature introduced in TendTo/rules_doxygen#30 lets us configure this path properly for all host OSes. Original-Bug: 434937497 Original change's description: > docs: Enable Doxylink > > Doxylink is a lightweight Sphinx extension that makes it easy > to link from the main pigweed.dev site (powered by Sphinx) > to the pigweed.dev/doxygen subsite (powered by Doxygen). > > Original-Bug: 426012010 > > Change-Id: I49c6c66a8bbb45dc05a47df0e526a5d5acf5a5a3 > Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/299993 > Pigweed-Auto-Submit: Kayce Basques <[email protected]> > Tests-Not-Needed: Kayce Basques <[email protected]> > Copybara-Verified: Copybara Prod <[email protected]> > Commit-Queue: Kayce Basques <[email protected]> > Lint: Lint 🤖 <[email protected]> > Reviewed-by: Armando Montanez <[email protected]> Original-Bug: 426012010 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/309434 Presubmit-Verified: CQ Bot Account <[email protected]> Original-Revision: 494717f520908dc9d351dc612b9741270d3f117d Rolled-Repo: https://fuchsia.googlesource.com/third_party/pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 4bdcd99f0c0c75..494717f520908d Roller-URL: https://cr-buildbucket.appspot.com/build/8707415919095582833 CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I5a66790d9e3e72a28a4b89167ceb6f2708bb543a Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1338284 Commit-Queue: GI Roller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29