Skip to content

Conversation

@dcharbonnier
Copy link

First step of migrating to es6, more to come.

@coveralls
Copy link

coveralls commented Jul 14, 2018

Pull Request Test Coverage Report for Build 17

  • 385 of 403 (95.53%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 89.108%

Changes Missing Coverage Covered Lines Changed/Added Lines %
index.js 385 403 95.53%
Files with Coverage Reduction New Missed Lines %
index.js 1 89.11%
Totals Coverage Status
Change from base Build 12: -0.6%
Covered Lines: 588
Relevant Lines: 638

💛 - Coveralls

@curran
Copy link

curran commented Jul 14, 2018

@dcharbonnier This is great to see!

Breaking support for invoking the constructor without new merits a major version bump, as it's a breaking API change. Perhaps worth considering to keep the tests unmodified, and make the API backwards-compatible.

Maybe something like this:

module.exports = function(...args) { return new ShareDbMongo(...args) };

@dcharbonnier
Copy link
Author

I'm in favor of breaking things when they are wrong, and it's just a matter of search/replace on your code, not in sharedb or any other plugin I'm aware of. Yes it's a start of a major version and I would label it alpha if you want to release it, there is more to come and potentially other breaking changes. We can also create a develop branch merge all those changes in it and release when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants