refactor(angular-query): move injectQueries to sub-path export #9655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughAdds an experimental export entry for inject-queries: new barrel module, build entry, and package export; updates knip workspace. The main index stops re-exporting injectQueries and that API is re-exposed via the new inject-queries-experimental entry. No runtime logic changes. Changes
Sequence Diagram(s)No sequence diagram (changes are configuration and export routing only). Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-09-02T17:57:33.184ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d87f3f2
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9655 +/- ##
===========================================
+ Coverage 45.51% 87.77% +42.25%
===========================================
Files 209 16 -193
Lines 8379 319 -8060
Branches 1906 75 -1831
===========================================
- Hits 3814 280 -3534
+ Misses 4118 34 -4084
+ Partials 447 5 -442
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
knip.json (1)
18-20: Include main index in knip entry to retain full analysis coverage.Currently only the new experimental entry is analyzed.
Apply:
- "packages/angular-query-experimental": { - "entry": ["src/inject-queries-experimental/index.ts"] - }, + "packages/angular-query-experimental": { + "entry": ["src/index.ts", "src/inject-queries-experimental/index.ts"] + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
knip.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-experimental/src/index.ts(0 hunks)packages/angular-query-experimental/src/inject-queries-experimental/index.ts(1 hunks)packages/angular-query-experimental/vite.config.ts(1 hunks)
💤 Files with no reviewable changes (1)
- packages/angular-query-experimental/src/index.ts
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
knip.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
PR: TanStack/query#9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/angular-query-experimental/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (2)
packages/angular-query-experimental/vite.config.ts (1)
114-114: LGTM on adding the extra build entry.Ensure the package.json export path matches the emitted folder name “inject-queries-experimental” from this entry. See package.json comment.
packages/angular-query-experimental/src/inject-queries-experimental/index.ts (1)
1-1: Barrel re-export looks good.Matches the intent to expose injectQueries via a dedicated experimental subpath.
arnoud-dv
force-pushed
the
move-inject-queries-to-subpath
branch
from
5cc52ae to
b3a2eff
Compare
arnoud-dv
force-pushed
the
move-inject-queries-to-subpath
branch
from
b3a2eff to
d87f3f2
Compare
1 task
Hellol77
pushed a commit
to Hellol77/query
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move as of yet non-functional
injectQueriesto separate sub-pathexperimental-inject-queriesto indicate its experimental status so it won't hold up releasing the other APIs as stable.Summary by CodeRabbit
New Features
Refactor
Chores