Skip to content

Conversation

@kuldeepkeshwar
Copy link
Contributor

No description provided.

@kuldeepkeshwar
Copy link
Contributor Author

@tannerlinsley this(/bin/sh: 1: jest: not found) is weird. any idea ? I just wanted to add the env variable (NODE_ENV=production) in CI(travis)

@tannerlinsley
Copy link
Collaborator

tannerlinsley commented Dec 2, 2019 via email

@size-plugin
Copy link
Contributor

size-plugin bot commented Dec 2, 2019

Size report for the changes in this PR:

sizes-cjs Overall size: 6.54 kB

 index.js ⏤  6.54 kB

sizes-es Overall size: 6.41 kB

 index.es.js ⏤  6.41 kB

commit: 6912fe0

like it?

⭐️ me 😊

@kuldeepkeshwar
Copy link
Contributor Author

@tannerlinsley yes you were correct. yarn doesn't install dev deps in case of NODE_ENV=production 😄.

  • Update rollup-plugin-sizeconfiguration to avoid writing files(size*.json) in non-ci environment

@tannerlinsley
Copy link
Collaborator

So when do they get written outside of ci?

@tannerlinsley tannerlinsley merged commit 1436140 into TanStack:master Dec 2, 2019
@kuldeepkeshwar
Copy link
Contributor Author

Bot automatically update them incase of any delta in sizes.

These files are source of truth for previous build stats. If we manually update them and CI runs after it then it won’t show any delta as sizes are already updated.

@tannerlinsley
Copy link
Collaborator

Ah, that makes sense :)

@nx-cloud
Copy link

nx-cloud bot commented Dec 11, 2024

View your CI Pipeline Execution ↗ for commit 6912fe0

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-25 16:40:31 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants