-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Prevent manually updating sizes-*.json #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tannerlinsley this( |
|
That Is strange. Never seen it. Maybe that’s causing yarn not to install dev deps? I would try making the env variable more specific to the build script instead of all of Travis.
Tanner Linsley
…On Dec 1, 2019, 9:26 PM -0700, anotherjsguy ***@***.***>, wrote:
@tannerlinsley this(/bin/sh: 1: jest: not found) is weird. any idea ? I just wanted to add the env variable (NODE_ENV=production) in CI(travis)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@tannerlinsley yes you were correct. yarn doesn't install dev deps in case of NODE_ENV=production 😄.
|
|
So when do they get written outside of ci? |
|
Bot automatically update them incase of any delta in sizes. These files are source of truth for previous build stats. If we manually update them and CI runs after it then it won’t show any delta as sizes are already updated. |
|
Ah, that makes sense :) |
|
View your CI Pipeline Execution ↗ for commit 6912fe0
☁️ Nx Cloud last updated this comment at |
No description provided.