Add legacy toggle for lobby names #336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing as CBA has implemented their own system for it, the TMF system is somewhat redundant. https://github.com/CBATeam/CBA_A3/wiki/Name-Groups-in-Lobby This PR simply adds a toggle setting for it, which is saved in profileNamespace.
Contributor
|
As mentioned in #262 a good way to solve this is to simply stop the TMF lobby names running if a |
Contributor
Author
|
Yeah it probably is though I'm unable to make sense of the code, and it also runs into a potential issue if CBA code is executed before TMF, removing the @ sign. |
Freddo3000
force-pushed
the
lobby-names-toggle
branch
from
b3560f5 to
a025af3
Compare
Contributor
Author
|
Talked with @Sniperhid, best way to resolve this would be to check missionConfigFile for template version, and create a new template version using the CBA system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing as CBA has implemented their own system for it, the TMF system is somewhat redundant. https://github.com/CBATeam/CBA_A3/wiki/Name-Groups-in-Lobby
This PR simply adds a toggle setting for it, which is saved in profileNamespace.
Resolves #262