🔃 [Magento Community Engineering] Community Contributions - 2.2-develop

Accepted Community Pull Requests:
 - magento#23119: [Backport] magento#22686 Shipment view fixed for Fatal error. (by @milindsingh)
 - magento#23114: [Backport]  Show exception message during SCD failure (by @ihor-sviziev)


Fixed GitHub Issues:
 - magento#22686: Shipment Create via API salesShipmentRepositoryV1 throw Fatal error in Admin Order -> Shipment -> View (reported by @milindsingh) has been fixed in magento#23119 by @milindsingh in 2.2-develop branch
   Related commits:
     1. 044befa

 - magento#22882: Static content deploy - Don't shows error message, just stack trace (reported by @ihor-sviziev) has been fixed in magento#23114 by @ihor-sviziev in 2.2-develop branch
   Related commits:
     1. 38b8333

Author: magento-engcom-team

app/code/Magento/Deploy/Service/DeployPackage.php

@@ -112,6 +112,8 @@ function () use ($package, $options, $skipLogging) {
     }
 
     /**
+     * Execute package deploy procedure when area already emulated
+     *
      * @param Package $package
      * @param array $options
      * @param bool $skipLogging
@@ -141,7 +143,9 @@ public function deployEmulated(Package $package, array $options, $skipLogging =
                 $this->errorsCount++;
                 $this->logger->critical($errorMessage);
             } catch (\Exception $exception) {
-                $this->logger->critical($exception->getTraceAsString());
+                $this->logger->critical(
+                    'Compilation from source ' . $file->getSourcePath() . ' failed' . PHP_EOL . (string)$exception
+                );
                 $this->errorsCount++;
             }
         }
@@ -224,7 +228,9 @@ private function checkIfCanCopy(PackageFile $file, Package $package, Package $pa
     private function checkFileSkip($filePath, array $options)
     {
         if ($filePath !== '.') {
+            // phpcs:ignore Magento2.Functions.DiscouragedFunction
             $ext = strtolower(pathinfo($filePath, PATHINFO_EXTENSION));
+            // phpcs:ignore Magento2.Functions.DiscouragedFunction
             $basename = pathinfo($filePath, PATHINFO_BASENAME);
             if ($ext === 'less' && strpos($basename, '_') === 0) {
                 return true;

app/code/Magento/Shipping/view/adminhtml/templates/view/items.phtml

@@ -14,14 +14,16 @@
         </thead>
         <?php $_items = $block->getShipment()->getAllItems() ?>
         <?php $_i = 0; foreach ($_items as $_item) :
-            if ($_item->getOrderItem()->getParentItem()) :
-                continue;
-            endif;
-            $_i++ ?>
-            <tbody class="<?= /* @noEscape */ $_i%2 ? 'odd' : 'even' ?>">
-                <?= $block->getItemHtml($_item) ?>
-                <?= $block->getItemExtraInfoHtml($_item->getOrderItem()) ?>
-            </tbody>
+            if (!empty($_item->getOrderItem())) :
+                if ($_item->getOrderItem()->getParentItem()) :
+                    continue;
+                endif;
+                $_i++ ?>
+                <tbody class="<?= /* @noEscape */ $_i%2 ? 'odd' : 'even' ?>">
+                    <?= $block->getItemHtml($_item) ?>
+                    <?= $block->getItemExtraInfoHtml($_item->getOrderItem()) ?>
+                </tbody>
+            <?php endif; ?>
         <?php endforeach; ?>
     </table>
 </div>