Require phpunit on dev only #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Okay, that sounds about right. However, strictly speaking, PHPUnit is a dependency, because you couldn't use any of the code inside this package without it. Anyway, since this is a special case (with the code of PHPUnit being outside the project itself), there you go! |
matthiasnoback
added a commit
that referenced
this pull request
Jun 20, 2015
Require phpunit on dev only
|
Thanks! 👍 |
greg0ire
added a commit
to greg0ire/SymfonyDependencyInjectionTest
that referenced
this pull request
Oct 19, 2016
It was sneakily moved back to require in SymfonyTest#61, without any explanation. Also see SymfonyTest#47, SymfonyTest#28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like you did here: https://packagist.org/packages/matthiasnoback/symfony-config-test
Users does not necessary want to download all phpunit package and dependencies on they own projects.