Skip to content

Conversation

@pamil
Copy link
Contributor

@pamil pamil commented Jun 10, 2016

No description provided.

@pamil pamil changed the title Drop unsupported Symfony versions and PhpUnit 3.7 support Drop unsupported Symfony versions and PhpUnit 3.7 Jun 10, 2016
.travis.yml Outdated
- SYMFONY_VERSION=2.8.* PHPUNIT_VERSION=^4.0
- SYMFONY_VERSION=2.8.* PHPUNIT_VERSION=^5.0
- SYMFONY_VERSION=3.0.* PHPUNIT_VERSION=^4.0
- SYMFONY_VERSION=3.0.* PHPUNIT_VERSION=^5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not make the change in this way. This will completely bloat the build matrix as every environment is now applied to each tested PHP version (meaning we talk about n times m jobs now). And by the way you dropped the build that was done on HHVM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@pamil pamil force-pushed the update-composer-and-travis branch from 4836c19 to 432bf99 Compare June 13, 2016 08:08
@matthiasnoback matthiasnoback merged commit 432bf99 into SymfonyTest:master Jun 18, 2016
@pamil pamil deleted the update-composer-and-travis branch June 19, 2016 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants