Skip to content

Allow Symfony 3 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2015
Merged

Allow Symfony 3 #27

merged 3 commits into from
Nov 12, 2015

Conversation

soullivaneuh
Copy link
Contributor

Also fixed composer.json and moved phpunit onto dev dependencies (this is not needed, some users use phpunit globally).

@soullivaneuh
Fix on improve composer.json
27fb4ef 
* Fix duplicate require section
* PHPUnit on require-dev only
@soullivaneuh soullivaneuh mentioned this pull request Nov 10, 2015
Merged
2 tasks
matthiasnoback added a commit that referenced this pull request Nov 12, 2015
@matthiasnoback
Merge pull request #27 from Soullivaneuh/sf3
502b6b7 
Allow Symfony 3
@matthiasnoback matthiasnoback merged commit 502b6b7 into SymfonyTest:master Nov 12, 2015
@soullivaneuh soullivaneuh deleted the sf3 branch November 12, 2015 16:18
@xabbuh
Copy link
Member

xabbuh commented Nov 17, 2015

Moving the phpunit/phpunit dependency to require-dev looks wrong to me as the classes from the package itself extend classes from PHPUnit.

@xabbuh
Copy link
Member

xabbuh commented Nov 17, 2015

see #28

@matthiasnoback
Copy link
Collaborator

@xabbuh I'm always tricked into the same kind of reasoning :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soullivaneuh @xabbuh @matthiasnoback