Add Browsersync options to scripts task #1074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when not using a js preprocessor, the page is refreshed multiple times in a short time.
I'm using Django on the backend and the local server hangs for a long time because of the multiple reloads (its faster to kill it and restart it). This is very noticeable when there are more than 30 js files.
This PR would fix this problem and possibly #1067.
A filter is also provided to only reload the changed script and stop unwanted files from being reloaded. I did this so that I can inject a controller instead of refreshing the browser. The way I pass the changed file is a little ugly, so if you want I can exclude it from the PR.