This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Ignore additional top-level directories #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukas-Stuehrk
suggested changes
Apr 3, 2021
There was a problem hiding this comment.
👍 Nice change, I like the idea that the default behavior and configuration for swift-doc does the "right" thing for most projects. Especially since it's still possible to include those directories if needed by providing their full path additionally in the list of paths.
There's a little logic bug, which needs to be fixed, otherwise the directories won't be excluded.
Lukas-Stuehrk
approved these changes
Apr 17, 2021
|
@Lukas-Stuehrk Seriously, thanks again for catching my mistake here. I'm excited to get this merged and cut a new beta soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #234
Building upon #229, which ignores hidden directories
./Tests/, this PR also ignores the following top-level directories:node_modulesPackagesPodsResources