This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Don't link to not included symbols in the Relationships section. #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukas-Stuehrk
force-pushed
the
FixRelationshipLinks
branch
from
19f23eb to
4982b02
Compare
Lukas-Stuehrk
added a commit
to Lukas-Stuehrk/swift-doc
that referenced
this pull request
Mar 25, 2021
Lukas-Stuehrk
force-pushed
the
FixRelationshipLinks
branch
from
bf523e0 to
8f1965e
Compare
mattt
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Nice work, @Lukas-Stuehrk. The only suggestion I have is to relabel the symbolFilter parameter as includingChildren to match the original declaration. Any objections?
Sources/swift-doc/Supporting Types/Components/Relationships.swift
Outdated
Show resolved
Hide resolved
Sources/swift-doc/Supporting Types/Components/Relationships.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Mattt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly the problem mentioned in #177, but a similar problem.
The problem described in #177 got a workaround in #204. Starting from there, symbols in the declaration don't have a link anymore.