-
Notifications
You must be signed in to change notification settings - Fork 225
SUMO-268804: Otel Collector monitoring App - Documentation #5712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chetanchoudhary-sumo, I see a few issues:
- You should change the name of the file to match the file ID (for example,
opentelemetry-collector-insights
). It makes it easier to track the file. - You need to create an entry in the
sidebars.ts
file for the new article so that it appears in the left navigation menu. - The dashboard screenshots are broken. You need to set up permissions so that they appear in the article.
- I question the location of the new article under https://help.sumologic.com/docs/integrations/hosts-operating-systems/opentelemetry/. @amee-sumo, can you tell @chetanchoudhary-sumo where you think the new article should go?
@chetanchoudhary-sumo, thank you for making the fixes! (@amee-sumo, let @chetanchoudhary-sumo know where the new article should go in the navigation structure.) |
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @chetanchoudhary-sumo. I made some minor changes (see commit "Updates from review").
After you fix the diagram issue and determine where to place the article in the left nav, I think it's ready to go.
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
docs/integrations/hosts-operating-systems/opentelemetry/opentelemetry-collector-insights.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @chetanchoudhary-sumo I've placed the doc in it's right place. Please view my commit to see the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few commits. Rest LGTM
Purpose of this pull request
This pull request adds Open Telemetry Monitoring app documentation
Select the type of change
Ticket (if applicable)
SUMO-268804