Skip to content

Conversation

chetanchoudhary-sumo
Copy link
Collaborator

Purpose of this pull request

This pull request adds Open Telemetry Monitoring app documentation

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

SUMO-268804

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Aug 21, 2025
@chetanchoudhary-sumo chetanchoudhary-sumo marked this pull request as ready for review August 22, 2025 11:42
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetanchoudhary-sumo, I see a few issues:

@jpipkin1
Copy link
Collaborator

@chetanchoudhary-sumo, thank you for making the fixes! (@amee-sumo, let @chetanchoudhary-sumo know where the new article should go in the navigation structure.)

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @chetanchoudhary-sumo. I made some minor changes (see commit "Updates from review").

After you fix the diagram issue and determine where to place the article in the left nav, I think it's ready to go.

Copy link
Collaborator

@sumoanema sumoanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amee-sumo
Copy link
Collaborator

Hi @chetanchoudhary-sumo I've placed the doc in it's right place. Please view my commit to see the changes.

Copy link
Collaborator

@amee-sumo amee-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few commits. Rest LGTM

@jpipkin1 jpipkin1 dismissed their stale review August 26, 2025 13:54

Requested changes were made.

@chetanchoudhary-sumo chetanchoudhary-sumo added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit c676027 Aug 27, 2025
7 checks passed
@chetanchoudhary-sumo chetanchoudhary-sumo deleted the otel-collector-doc branch August 27, 2025 14:03
@kimsauce kimsauce restored the otel-collector-doc branch August 30, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants