Use actual filename for the temporary files #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #29 pydocstyle actually uses the filename to decide if or how some rules apply. For example it treats `__init__.py` and `_some_module.py` differently. Instead of generating a random filename, generate a randomly named directory with the actual file in it.
For whatever reason, I get PERMISSION_DENIED errors when unlinking (on Windows) occasionally. Retry the operation to mitigate.
Member
Author
|
This is too much code for a plugin but we could pull this method into SublimeLinter itself later. Generally having the original filename in a temporary directory seems to be a superior solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
pydocstyle actually uses the filename to decide if or how some rules
apply. For example it treats
__init__.pyand_some_module.pydifferently.
Instead of generating a random filename, generate a randomly named
directory with the actual file in it.