Fix shrinkWrap to shrinkwrap most elements #679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tneotia do you see anything that your PR does and mine doesn't? If so, which one do we want to merge? |
|
Nope they look to have the same features, just your code is more concise so I'd prefer to merge yours. Nice work! I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
Builds on #675.
Fixes #671 and fixes #565.
shrinkWrap: trueand'html': Style(backgroundColor: Colors.yellow),inStyle():(Some elements were removed, see below)
Limitations
It will not shrinkwrap:
TextAlignbecause the full width is needed to represent those correctly, e.g.TextAlign.centerRegression testing needed, I don't think there are any. If there are it'll be with layout - there shouldn't be any errors in code.