-
-
Notifications
You must be signed in to change notification settings - Fork 918
[Proof-of-concept] Image render API #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erickok
merged 6 commits into
Sub6Resources:master
from
vrtdev:feature/498-image-render-api
Feb 8, 2021
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1f40f96
Image render API proposal
erickok 0bd3132
Extend custom image API with svg support
erickok 645b49b
Add unit tests for all image source matchers
erickok d0b9319
Merge remote-tracking branch 'upstream/master' into feature/498-image…
erickok 321bbfa
Apply fix from #523 back into new image loading API
erickok 035c0a2
Code formatting on test with long literals
erickok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import 'dart:convert'; | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_html/html_parser.dart'; | ||
| import 'package:flutter_svg/flutter_svg.dart'; | ||
| import 'package:html/dom.dart' as dom; | ||
|
|
||
| typedef ImageSourceMatcher = bool Function( | ||
| Map<String, String> attributes, | ||
| dom.Element element, | ||
| ); | ||
|
|
||
| ImageSourceMatcher base64UriMatcher() => (attributes, element) => | ||
| attributes["src"].startsWith("data:image") && | ||
| attributes["src"].contains("base64,"); | ||
|
|
||
| ImageSourceMatcher networkSourceMatcher({ | ||
| List<String> schemas: const ["https", "http"], | ||
| List<String> domains, | ||
| String extension, | ||
| }) => | ||
| (attributes, element) { | ||
| final src = Uri.parse(attributes["src"]); | ||
| return schemas.contains(src.scheme) && | ||
| (domains == null || domains.contains(src.host)) && | ||
| (extension == null || src.path.endsWith(".$extension")); | ||
| }; | ||
|
|
||
| typedef ImageRender = Widget Function( | ||
| RenderContext context, | ||
| Map<String, String> attributes, | ||
| dom.Element element, | ||
| ); | ||
|
|
||
| ImageRender base64ImageRender() => (context, attributes, element) { | ||
| final decodedImage = | ||
| base64.decode(attributes["src"].split("base64,")[1].trim()); | ||
| precacheImage( | ||
| MemoryImage(decodedImage), | ||
| context.buildContext, | ||
| onError: (exception, StackTrace stackTrace) { | ||
| context.parser.onImageError?.call(exception, stackTrace); | ||
| }, | ||
| ); | ||
| return Image.memory( | ||
| decodedImage, | ||
| frameBuilder: (ctx, child, frame, _) { | ||
| if (frame == null) { | ||
| return Text(attributes["alt"] ?? "", | ||
| style: context.style.generateTextStyle()); | ||
| } | ||
| return child; | ||
| }, | ||
| ); | ||
| }; | ||
|
|
||
| ImageRender networkImageRender({ | ||
| Map<String, String> headers, | ||
| double width, | ||
| double height, | ||
| Widget Function(String) altWidget, | ||
| }) => | ||
| (context, attributes, element) { | ||
| precacheImage( | ||
| NetworkImage(attributes["src"]), | ||
| context.buildContext, | ||
| onError: (exception, StackTrace stackTrace) { | ||
| context.parser.onImageError?.call(exception, stackTrace); | ||
| }, | ||
| ); | ||
| return Image.network( | ||
| attributes["src"], | ||
| headers: headers, | ||
| width: width, | ||
| height: height, | ||
| frameBuilder: (ctx, child, frame, _) { | ||
| if (frame == null) { | ||
| return altWidget.call(attributes["alt"]) ?? | ||
| Text(attributes["alt"] ?? "", | ||
| style: context.style.generateTextStyle()); | ||
| } | ||
| return child; | ||
| }, | ||
| ); | ||
| }; | ||
|
|
||
| ImageRender svgNetworkImageRender() => (context, attributes, element) { | ||
| return SvgPicture.network( | ||
| attributes["src"], | ||
| ); | ||
| }; | ||
|
|
||
| final Map<ImageSourceMatcher, ImageRender> defaultImageRenders = { | ||
| base64UriMatcher(): base64ImageRender(), | ||
| networkSourceMatcher(extension: "svg"): svgNetworkImageRender(), | ||
| networkSourceMatcher(): networkImageRender(), | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.