details tag support #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request. I will review this soon! |
Sub6Resources
requested changes
Nov 5, 2018
lib/html_parser.dart
Outdated
|
|
||
| typedef CustomRender = Widget Function(dom.Node node, List<Widget> children); | ||
| typedef OnLinkTap = void Function(String url); | ||
| typedef ParseNodeFunction = List<Widget> Function(List<dom.Node> nodeList); |
There was a problem hiding this comment.
Rather than creating a custom callback to parse widgets, just pass in the list of children Widgets to the Widget.
There was a problem hiding this comment.
I left it after refactoring because it is also needed to build
node content, but we cannot know in advance if there is a "summary" tag, or have to determine the content of the tag outside the class, which seems to me not the best way to structure the code.
|
This package has changed a great deal and will continue to change a great deal since you first opened this pull request. I'm going to close this pull request for now. If you are willing to make the changes to make this compatible with the most recent version, including the Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, add StatefulWidget for details tag.