Skip to content

asset support for <img> #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2019
Merged

asset support for <img> #162

merged 1 commit into from
Dec 14, 2019

Conversation

namiwang
Copy link
Contributor

@namiwang namiwang commented Sep 19, 2019 •
edited
Loading

use to display AssetImage

@namiwang
Copy link
Contributor Author

@Sub6Resources Hi do I need to add a test for this?

@Sub6Resources
Copy link
Owner

Yeah, some sort of test would be best. Do you think we could make the prefix asset:// instead of just asset:? This will help keep things consistent with the http:// and https:// prefixes.

@Sub6Resources Sub6Resources added enhancement New feature or request medium-priority labels Oct 7, 2019
@Sub6Resources Sub6Resources added this to the 1.0.0 milestone Oct 7, 2019
@Sub6Resources Sub6Resources self-requested a review October 7, 2019 23:57
@namiwang
Copy link
Contributor Author

namiwang commented Oct 8, 2019

Idk, assets:// is not a real protocol, assets: seems consistent with data:.

I'm fine with both really.

@maheshbhattaraai
Copy link

How can we return cached network image??

@Sub6Resources
Copy link
Owner

@maheshbhattaraai PR #183 should allow for returning cached network images.

@Sub6Resources Sub6Resources merged commit 7491206 into Sub6Resources:master Dec 14, 2019
@tneotia tneotia mentioned this pull request Jan 17, 2021
Closed
@fahami fahami mentioned this pull request Oct 12, 2022
Closed
@Equirinya Equirinya mentioned this pull request Aug 5, 2023
Open
@priyankgandhi0 priyankgandhi0 mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sub6Resources Sub6Resources Sub6Resources approved these changes

+1 more reviewer

@maheshbhattaraai maheshbhattaraai maheshbhattaraai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request medium-priority

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@namiwang @Sub6Resources @maheshbhattaraai