Skip to content

Consolidate metadata types and expose OnUpdateCallback #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Consolidate metadata types and expose OnUpdateCallback #852

merged 1 commit into from
Jul 21, 2022

Conversation

Stuk
Copy link
Owner

@Stuk Stuk commented Jul 20, 2022

Metadata types were duplicated as Metadata (not exported) and JSZipMetadata (exported, and missing null type for currentFile).

This PR gets rid of Metadata and consolidates under JSZipMetadata.

From #851

@Stuk Stuk mentioned this pull request Jul 20, 2022
Closed
emilbonnek
emilbonnek suggested changes Jul 21, 2022
View reviewed changes
Copy link

@emilbonnek emilbonnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and provides a smoother typesafe story :)

Only got a tiny thing with currentFile not being nullable as before.

@Stuk Stuk merged commit f299cce into main Jul 21, 2022
@Stuk Stuk deleted the metadata-ts branch July 21, 2022 18:28
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 17, 2023
Open
@NateRadebaugh NateRadebaugh mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@emilbonnek emilbonnek emilbonnek requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stuk @emilbonnek