Skip to content

HOTFIX: File Lattice Type_IDs #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briandrawert merged 2 commits into from
Jan 17, 2023
Merged

HOTFIX: File Lattice Type_IDs #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7b2435
Fixed issue with type_ids in XML mesh and mesh IO lattices.
BryanRumsey Jan 5, 2023
79503f0
Testing plotly fix
BryanRumsey Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spatialpy/core/domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,8 @@ def plot_types(self, width=None, height=None, colormap=None, size=None, title=No

if return_plotly_figure:
return fig
init_notebook_mode(connected=True)
# init_notebook_mode(connected=True)
init_notebook_mode()
iplot(fig)
return

Expand Down
4 changes: 2 additions & 2 deletions spatialpy/core/lattice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ def __get_types(self):

if self.type_ids is not None:
type_id = self.type_ids[type_id]
type_ids[int(ndx)] = f"type_{type_id}"
type_ids[int(ndx)] = type_id
except ValueError as err:
errmsg = f"Could not read in subdomain file, error on line {lnum}: {line}"
raise LatticeError(errmsg) from err
Expand Down Expand Up @@ -685,7 +685,7 @@ def __get_types(self):

if self.type_ids is not None:
type_id = self.type_ids[type_id]
type_ids[int(ndx)] = f"type_{type_id}"
type_ids[int(ndx)] = type_id
except ValueError as err:
errmsg = f"Could not read in subdomain file, error on line {lnum}: {line}"
raise LatticeError(errmsg) from err
Expand Down