Skip to content

HOTFIX: Remove Action #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briandrawert merged 2 commits into from
Dec 22, 2022
Merged

HOTFIX: Remove Action #334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05903d2
Fixed issue with applying remove actions.
BryanRumsey Dec 16, 2022
d8bdc8a
Added axis to fix.
BryanRumsey Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spatialpy/core/domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,9 @@ def apply_remove_action(self, action):

# remove the particles that fall within the defined region
on_boundary = self.find_boundary_points(update=True)
for v_ndx in range(self.get_num_voxels()):
if action['geometry'].inside(self.coordinates()[v_ndx, :], on_boundary[v_ndx]):
for v_ndx, vertex in enumerate(self.vertices):
if action['geometry'].inside(vertex, on_boundary[v_ndx]):
self.vertices = numpy.delete(self.vertices, v_ndx, 0)
self.type_id = numpy.delete(self.type_id, v_ndx, 0)
self.vol = numpy.delete(self.vol, v_ndx)
self.mass = numpy.delete(self.mass, v_ndx)
Expand Down