Skip to content

Conversation

@BryanRumsey
Copy link
Contributor

@BryanRumsey BryanRumsey commented Aug 5, 2022

Changes to Domain

New Attributes

  • actions is a list containing domain actions

Changes to __init__

  • New arg actions allows action to be passed in when a domain is constructed

New Functions

  • add_fill_action constructs a fill action and either applies it or adds it to actions
  • add_remove_action constructs a remove action and either applies it or adds it to actions
  • add_set_action constructs a set action and either applies it or adds it to actions
  • apply_actions applies all actions stored in actions in list order
  • apply_fill_action validates and applies the given fill action
  • apply_remove_action validates and applies the given remove action
  • apply_set_action validates and applies the given set action

Refactored Functions

  • fill_with_particles now uses fill actions and lattices to execute its functionality. Applies actions by default.
  • set_properties now uses set actions to execute its functionality. Applies actions by default.
  • create_2D_domain now uses action to create the domain.
  • create_3D_domain now uses action to create the domain.
  • read_xml_mesh now uses action to create the domain.
  • read_msh_file now uses action to create the domain.
  • import_meshio_object now uses action to create the domain.
  • read_stochss_domain now uses action to create the domain.

@BryanRumsey BryanRumsey linked an issue Aug 7, 2022 that may be closed by this pull request
5 tasks
@BryanRumsey BryanRumsey linked an issue Aug 8, 2022 that may be closed by this pull request
6 tasks
@BryanRumsey BryanRumsey mentioned this pull request Aug 15, 2022
@briandrawert briandrawert merged commit f180410 into develop Aug 15, 2022
@briandrawert briandrawert deleted the actions-and-apply-funcs branch August 15, 2022 16:28
@BryanRumsey BryanRumsey mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

3 participants