Skip to content

Timespan Fix #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandrawert merged 14 commits into from
Oct 18, 2021
Merged

Timespan Fix #178

briandrawert merged 14 commits into from
Oct 18, 2021

Conversation

@BryanRumsey
Copy link
Contributor

@BryanRumsey BryanRumsey commented Oct 12, 2021

No description provided.

@BryanRumsey BryanRumsey self-assigned this Oct 12, 2021
@BryanRumsey BryanRumsey linked an issue Oct 12, 2021 that may be closed by this pull request
Model.tspan and result.tspan are not the same length #169
Closed
briandrawert
briandrawert reviewed Oct 12, 2021
View reviewed changes
briandrawert
briandrawert previously approved these changes Oct 12, 2021
View reviewed changes
@briandrawert briandrawert self-requested a review October 12, 2021 19:24
@briandrawert briandrawert dismissed their stale review October 12, 2021 19:24

Prematurely approved

@briandrawert
Copy link
Member

briandrawert commented Oct 12, 2021

Error in the C++ backend, model.tspan = array([0. , 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1. ]) however, it appears that a .vtk file is generated at every step. The code seg-faulted after creating output7331.vtk

@briandrawert
Copy link
Member

briandrawert commented Oct 12, 2021

Screenshot from 2021-10-12 12-31-56

@BryanRumsey BryanRumsey linked an issue Oct 15, 2021 that may be closed by this pull request
set timestep size more intelligently #89
Closed
@seanebum seanebum self-requested a review October 18, 2021 16:45
@briandrawert briandrawert merged commit 96004a0 into develop Oct 18, 2021
@briandrawert briandrawert deleted the tspan-fix branch October 18, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandrawert briandrawert briandrawert approved these changes

@seanebum seanebum seanebum approved these changes

Assignees

@BryanRumsey BryanRumsey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Model.tspan and result.tspan are not the same length set timestep size more intelligently

4 participants

@BryanRumsey @briandrawert @seanebum