Skip to content

Add new assertion 'assertCount' #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2024
Merged

Add new assertion 'assertCount' #20

merged 3 commits into from
Sep 23, 2024

Conversation

JoseVte
Copy link
Contributor

@JoseVte JoseVte commented Sep 17, 2024

  • Add new assertion 'assertCount'
  • Allow search using whereIn

@CoolDude53
Copy link

@JoseVte any chance you could add support for whereNotIn too?

@JoseVte
Copy link
Contributor Author

JoseVte commented Sep 20, 2024

I added whereNotIn into the filters, and some tests to check the behaviour

@Sti3bas
Copy link
Owner

Sti3bas commented Sep 23, 2024

@JoseVte can you please fix the tests?

@Sti3bas Sti3bas merged commit 774ec43 into Sti3bas:master Sep 23, 2024
14 checks passed
@Sti3bas
Copy link
Owner

Sti3bas commented Sep 23, 2024

@JoseVte thank you very much for the PR!

Released in https://github.com/Sti3bas/laravel-scout-array-driver/releases/tag/v4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseVte @CoolDude53 @Sti3bas