-
Notifications
You must be signed in to change notification settings - Fork 3
Sql history #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidhagan
wants to merge
75
commits into
master
Choose a base branch
from
sql-history
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sql history #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd sbt. Still can't get the h2 driver to connect properly, but that's the next challenge
…using their custom socket factories and credential metadata
… and now the sql connects to cloudSql correctly
dougecko
reviewed
Aug 6, 2020
build.sbt
Outdated
| "com.sun.mail" % "javax.mail" % "1.6.2", | ||
| "com.hacklanta" %% "lift-formality_3.3" % "1.2.0", | ||
| "io.github.classgraph" % "classgraph" % "4.6.18", | ||
| "com.sksamuel.scrimage" % "scrimage-core_2.12" % "3.0.0-alpha4", |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need alpha dependencies?
dougecko
reviewed
Aug 6, 2020
| @@ -0,0 +1,359 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you hack this from the original version? (Why copy into the project?)
Collaborator
Author
|
yes. Google's library is inadequate and unextendable, so I've had to hack
this one file.
…On Fri, 7 Aug 2020, 07:41 Doug Hagan, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java
<#1 (comment)>
:
> @@ -0,0 +1,359 @@
+/*
Did you hack this from the original version? (Why copy into the project?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYVB6LWGWZCRU4CGR2IZMDR7MPQXANCNFSM4PVQYD6A>
.
|
Collaborator
Author
|
probably don't need this one. will check.
…On Fri, 7 Aug 2020, 07:38 Doug Hagan, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In build.sbt
<#1 (comment)>
:
> + "org.specs2" %% "specs2-core" % "3.9.4" % "test",
+ "com.h2database" % "h2" % "1.4.187",
+ "com.github.dakatsuka" %% "akka-http-oauth2-client" % "0.1.0",
+ "io.lemonlabs" %% "scala-uri" % "1.4.4",
+ "com.google.api-client" % "google-api-client" % "1.25.0",
+ "com.softwaremill.sttp" %% "core" % "1.5.0",
+ "com.softwaremill.sttp" %% "okhttp-backend" % "1.5.11",
+ "org.ekrich" %% "sconfig" % "0.8.0",
+ "javax.servlet" % "javax.servlet-api" % "3.0.1" % "provided",
+ "org.eclipse.jetty" % "jetty-webapp" % "9.4.11.v20180605",
+ "net.rcarz" % "jira-client" % "0.6.3-IHTSDO",
+ "javax.mail" % "javax.mail-api" % "1.6.2",
+ "com.sun.mail" % "javax.mail" % "1.6.2",
+ "com.hacklanta" %% "lift-formality_3.3" % "1.2.0",
+ "io.github.classgraph" % "classgraph" % "4.6.18",
+ "com.sksamuel.scrimage" % "scrimage-core_2.12" % "3.0.0-alpha4",
Do we need alpha dependencies?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYVB6MQ27VZSVPH7NET3Q3R7MPFBANCNFSM4PVQYD6A>
.
|
…ch isn't reloadable/changeable after boot
…the app, and made it so that the login link for github will take you directly to the requested url if you're already logged in
…it can be re-rendered by some other system.
… independently styleable
… should be MUCH lighter on the client because it's not doing constant re-renders
…quite well for much larger datasets
…, and also added two more endpoints to return history for entire servers or for entire services
Setting the default login page to /simple
Update Dashboard.scala
…eHandler to handle cookies which start with . but are willing to accept undotted uris, so that https://a.b.c uses a cookie which requires .a.b.c, which is now handled by browsers.
…'re subscribed to a level of severity. Tuned many debug statements down to trace. Reduced default apache.http packages down in log visibility. Shifted default .sbt mode to production so that notifiers work and can be tested. No change on frontend.
…ing use of it to use the apache 5.1 async client. The existing synchronous client is still accessible, just in case there's any weirdness which is discovered later. Both script checks and normal checks have been upgraded to support full async behaviour, and this has been tested against our existing set of checks.
…ys which provably work for it
…tp client. This means that we should now be able to move quacker to using the new branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings an alternate history backend (sql driver with an apache db commons threadpool) to save checkresults, so that we can build a service health dashboard with historical data, and it also brings an update to lift, scala and some of the libraries.