Skip to content

Remove automatic STACKONE_ACCOUNT_ID environment variable loading #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 1 commit into from
Aug 18, 2025
Merged

Remove automatic STACKONE_ACCOUNT_ID environment variable loading #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ tools = StackOneToolSet(include_tools=["hris_*", "!hris_create_*"])
# Uses environment variables or direct configuration
toolset = StackOneToolSet(
api_key="your-api-key", # or STACKONE_API_KEY env var
account_id="optional-id" # or STACKONE_ACCOUNT_ID env var
account_id="optional-id" # explicit account ID required
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'explicit account ID required' is contradictory since the parameter is still optional (as indicated by 'optional-id'). Consider changing to 'explicit account ID if needed' or similar to clarify that while the parameter is optional, when provided it must be explicit.

Suggested change
account_id="optional-id" # explicit account ID required
account_id="optional-id" # explicit account ID if needed

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@glebedel glebedel Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryoppippi good flag here from copilot, is this optional (as the value seems to indicate) or is this required?

Copy link
Member Author

@ryoppippi ryoppippi Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no we can set it later.

)
```

Expand Down
4 changes: 2 additions & 2 deletions stackone_ai/toolset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def __init__(

Args:
api_key: Optional API key. If not provided, will try to get from STACKONE_API_KEY env var
account_id: Optional account ID. If not provided, will try to get from STACKONE_ACCOUNT_ID env var
account_id: Optional account ID
base_url: Optional base URL override for API requests. If not provided, uses the URL from the OAS

Raises:
Expand All @@ -55,7 +55,7 @@ def __init__(
"STACKONE_API_KEY environment variable"
)
self.api_key: str = api_key_value
self.account_id = account_id or os.getenv("STACKONE_ACCOUNT_ID")
self.account_id = account_id
self.base_url = base_url

def _parse_parameters(self, parameters: list[dict[str, Any]]) -> dict[str, dict[str, str]]:
Expand Down