Remove automatic STACKONE_ACCOUNT_ID environment variable loading

[ryoppippi]

Summary

This PR removes the automatic loading of the STACKONE_ACCOUNT_ID environment variable from the StackOneToolSet initialization. This change provides more explicit control over account ID configuration.

Changes Made

• Removed automatic fallback to os.getenv(STACKONE_ACCOUNT_ID) in StackOneToolSet.init()
• Updated docstring to reflect that account_id parameter requires explicit provision
• Updated CLAUDE.md documentation to clarify the new behavior

Rationale

• Improves code clarity by requiring explicit account ID provision when needed
• Prevents unexpected behavior from environment variables
• Maintains consistency with explicit configuration patterns
• The API key still supports environment variable fallback as it is required for authentication

Testing

• All existing tests pass without modification
• No breaking changes to the public API (account_id parameter remains optional)
• Type checking and linting pass

Test plan

• Run existing test suite to ensure no regressions
• Verify linting and type checking pass
• Confirm that account_id=None behavior works as expected

---

Summary by cubic

Removed automatic loading of STACKONE_ACCOUNT_ID in StackOneToolSet; account_id is now used only when passed explicitly. This makes configuration predictable while keeping STACKONE_API_KEY env fallback; docs updated.

• Migration
  • If you relied on the STACKONE_ACCOUNT_ID env var, pass account_id explicitly when creating StackOneToolSet.

[Copilot]

Pull Request Overview

This PR removes automatic environment variable loading for the STACKONE_ACCOUNT_ID in the StackOneToolSet initialization. The change requires explicit provision of the account_id parameter when needed, improving code clarity and preventing unexpected behavior from environment variables.

Key Changes

• Removed automatic fallback to os.getenv("STACKONE_ACCOUNT_ID") in StackOneToolSet.init()
• Updated docstring and documentation to clarify that account_id requires explicit provision
• Maintained the API key's environment variable fallback for authentication purposes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
stackone_ai/toolset.py	Removed automatic STACKONE_ACCOUNT_ID environment variable loading and updated docstring
CLAUDE.md	Updated documentation to clarify that account_id requires explicit provision

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The comment 'explicit account ID required' is contradictory since the parameter is still optional (as indicated by 'optional-id'). Consider changing to 'explicit account ID if needed' or similar to clarify that while the parameter is optional, when provided it must be explicit.

Suggested change

	account_id="optional-id" # explicit account ID required
	account_id="optional-id" # explicit account ID if needed

[glebedel]

@ryoppippi good flag here from copilot, is this optional (as the value seems to indicate) or is this required?

[ryoppippi]

no we can set it later.

[cubic-dev-ai]

No issues found across 2 files. Review in cubic

[glebedel]

LGTM

[glebedel]

@ryoppippi good flag here from copilot, is this optional (as the value seems to indicate) or is this required?