refactor: simplify meta tool names to meta_search_tools and meta_execute_tool #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prefix - Rename meta_filter_relevant_tools to meta_search_tools_filter_relevant_tools - Rename meta_execute_tool to meta_search_tools_execute_tool - Update all references in README, examples, and tests - Maintain backward compatibility in functionality - Tests pass with new naming convention
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 4 files. Review in cubic
NicolasBelissent
previously approved these changes
Aug 14, 2025
- Update README section title and descriptions - Update all comments and documentation text - Update example file comments and descriptions - Update test descriptions and error messages - Update JSDoc comments in tool.ts - Update mock comments for consistency
mattzcarey
previously requested changes
Aug 14, 2025
Contributor
There was a problem hiding this comment.
naming should be
meta_search_tools
meta_execute_tool
Member
Author
There was a problem hiding this comment.
oh okay so meta_filter_relevant_tools to meta_search_tools ??
@mattzcarey
ryoppippi
changed the title
…ute_tool - Change meta_search_tools_filter_relevant_tools to meta_search_tools - Change meta_search_tools_execute_tool to meta_execute_tool - Update all references in README, examples, and tests - Maintain full functionality with simpler naming
ryoppippi
force-pushed
the
rename-meta-tools-to-meta-search-tools
branch
from
05692d0 to
f893c84
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the meta tool naming convention by shortening the tool names for better usability. The changes rename meta_search_tools_filter_relevant_tools to meta_search_tools and meta_search_tools_execute_tool to meta_execute_tool.
- Updates tool name constants and references in the core implementation
- Updates all documentation, examples, and test files to use the new simplified names
- Maintains full functionality while improving API intuitiveness
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tool.ts | Updates tool name constants and references in function descriptions |
| src/tests/meta-tools.spec.ts | Updates test descriptions, tool lookups, and assertions to use new names |
| mocks/handlers.ts | Updates comment to reflect new "meta search tools" terminology |
| examples/meta-tools.ts | Updates all examples and comments to use new tool names |
| README.md | Updates documentation to use new "Meta Search Tools" terminology and tool names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mattzcarey
reviewed
Aug 18, 2025
mattzcarey
reviewed
Aug 18, 2025
mattzcarey
reviewed
Aug 18, 2025
mattzcarey
reviewed
Aug 18, 2025
mattzcarey
reviewed
Aug 18, 2025
mattzcarey
suggested changes
Aug 18, 2025
src/tool.ts
Outdated
| return oramaDb; | ||
| } | ||
|
|
||
| export function metaFilterRelevantTools(oramaDb: OramaDb, allTools: BaseTool[]): BaseTool { |
Contributor
There was a problem hiding this comment.
can you change this function name for consistency
mattzcarey
approved these changes
Aug 18, 2025
mattzcarey
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the meta tool naming convention for better usability:
meta_search_tools_filter_relevant_tools→meta_search_toolsmeta_search_tools_execute_tool→meta_execute_toolChanges Made
src/tool.ts): Updated tool name constants and referencesREADME.md): Updated all examples and references to use new tool namesexamples/meta-tools.ts): Updated all usage examples with new tool namessrc/tests/meta-tools.spec.ts): Updated test descriptions, tool lookups, and assertionsTesting
Impact
This is a breaking change for users currently referencing these tool names directly. Users will need to update their code to use the new tool names:
```typescript
// Before
const filterTool = metaTools.getTool("meta_search_tools_filter_relevant_tools");
const executeTool = metaTools.getTool("meta_search_tools_execute_tool");
// After
const filterTool = metaTools.getTool("meta_search_tools");
const executeTool = metaTools.getTool("meta_execute_tool");
```
The simplified names make the API more intuitive and easier to remember while maintaining full functionality.