Skip to content

chore(nix): migrate lefthook from npm to nix #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 1 commit into from
Jan 13, 2026
+6 −106
Merged

chore(nix): migrate lefthook from npm to nix #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@

# security
gitleaks

# git hooks
lefthook
];

shellHook = ''
Expand All @@ -47,6 +50,9 @@
echo "📦 Installing dependencies..."
pnpm install --frozen-lockfile
fi
# Install lefthook git hooks
lefthook install > /dev/null 2>&1
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: lefthook install redirects stderr to /dev/null, so hook-install failures are silent and the devshell keeps running without required hooks. Let stderr surface (or explicitly handle failures) so developers notice problems.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At flake.nix, line 55:

<comment>`lefthook install` redirects stderr to `/dev/null`, so hook-install failures are silent and the devshell keeps running without required hooks. Let stderr surface (or explicitly handle failures) so developers notice problems.</comment>

<file context>
@@ -47,6 +50,9 @@
               fi
+
+              # Install lefthook git hooks
+              lefthook install > /dev/null 2>&1
             '';
           };
</file context>
Suggested change
lefthook install > /dev/null 2>&1
lefthook install > /dev/null

Comment on lines +54 to +55
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error suppression for the lefthook install command may hide important installation failures. If lefthook fails to install git hooks (e.g., due to permissions issues or missing configuration), developers won't be notified. Consider either:

  1. Allowing errors to display so developers can see if something goes wrong
  2. Adding a conditional check to verify the installation succeeded
  3. At minimum, only suppressing stdout while keeping stderr visible: lefthook install > /dev/null
Suggested change
# Install lefthook git hooks
lefthook install > /dev/null 2>&1
# Install lefthook git hooks (suppress stdout but keep stderr visible)
lefthook install > /dev/null

Copilot uses AI. Check for mistakes.
'';
};
}
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
"ai": "catalog:dev",
"hono": "catalog:dev",
"knip": "catalog:dev",
"lefthook": "catalog:dev",
"msw": "catalog:dev",
"openai": "catalog:peer",
"publint": "catalog:dev",
Expand Down
103 changes: 0 additions & 103 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ catalogs:
'@vitest/coverage-v8': ^4.0.15
hono: ^4.9.10
knip: ^5.72.0
lefthook: ^2.0.8
msw: ^2.10.4
publint: ^0.3.12
tsdown: ^0.17.2
Expand Down Expand Up @@ -55,7 +54,6 @@ minimumReleaseAgeExclude:

onlyBuiltDependencies:
- esbuild
- lefthook
- msw

shellEmulator: true
Expand Down
Loading