Skip to content

fix(lefthook): use pnpm #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 1 commit into from
Dec 12, 2025
Merged

fix(lefthook): use pnpm #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lefthook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ pre-commit:
jobs:
- name: oxlint
glob: '*.{ts,tsx,js,jsx,mts,cts}'
run: bun oxlint --max-warnings=0 --type-aware --type-check --fix {staged_files}
run: pnpm oxlint --max-warnings=0 --type-aware --type-check --fix {staged_files}
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command pnpm oxlint should be pnpm exec oxlint or use the package.json script pnpm run format:oxlint. When running binaries from node_modules/.bin with pnpm, you need to use pnpm exec to execute them directly, or reference the npm script. The current command may fail because pnpm doesn't automatically run binaries like bun does.

Suggested change
run: pnpm oxlint --max-warnings=0 --type-aware --type-check --fix {staged_files}
run: pnpm exec oxlint --max-warnings=0 --type-aware --type-check --fix {staged_files}

Copilot uses AI. Check for mistakes.
stage_fixed: true
- name: oxfmt
glob: '*'
run: bun oxfmt --no-error-on-unmatched-pattern {staged_files}
run: pnpm oxfmt --no-error-on-unmatched-pattern {staged_files}
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command pnpm oxfmt should be pnpm exec oxfmt or use the package.json script pnpm run format:oxfmt. When running binaries from node_modules/.bin with pnpm, you need to use pnpm exec to execute them directly, or reference the npm script. The current command may fail because pnpm doesn't automatically run binaries like bun does.

Suggested change
run: pnpm oxfmt --no-error-on-unmatched-pattern {staged_files}
run: pnpm exec oxfmt --no-error-on-unmatched-pattern {staged_files}

Copilot uses AI. Check for mistakes.
stage_fixed: true

push:
pre-push:
jobs:
- name: knip
run: pnpm run lint:knip
Loading