Consolidate DEFAULT_BASE_URL into existing constants.ts #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a central consts.ts file with DEFAULT_BASE_URL constant and use it as the default value in StackOneToolSet constructor. This allows users to use the SDK without explicitly providing a baseUrl. Closes #149
Base automatically changed from
claude/fix-issue-149-01FJuzkd3XSwVjj6zK6vC8gn
to
main
December 9, 2025 10:00
Move DEFAULT_BASE_URL from consts.ts to constants.ts to maintain consistent naming convention. Updated all imports accordingly and removed consts.ts file. Co-authored-by: ryoppippi <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on adding baseURL default implementation
Consolidate DEFAULT_BASE_URL into existing constants.ts
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #164 to maintain consistent naming conventions for constant files.
Changes
DEFAULT_BASE_URLfromsrc/consts.tsto existingsrc/constants.tssrc/index.ts,src/toolsets/stackone.ts, andsrc/tools/feedback.tssrc/consts.tsThe codebase now uses a single
constants.tsfile for all constants instead of splitting them across multiple files.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Summary by cubic
Adds a safe default baseURL to the client and clarifies how it’s chosen, so apps don’t need to pass it every time and requests land in the right environment.
Written for commit 1d82c9b. Summary will update automatically on new commits.