-
Notifications
You must be signed in to change notification settings - Fork 3
docs: remove meta tools implementation details from README #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove meta tools implementation details from README #138
Conversation
Remove reference to "Orama's BM25 algorithm" from the Meta Tools section to keep documentation focused on user-facing functionality rather than internal implementation details. This change: - Removes mention of specific algorithms (BM25, Orama) - Keeps the focus on what users can do (discover and execute tools) - Aligns with the documentation in agents/typescript/meta-tools.mdx - Maintains consistency with SDK documentation standards Users don't need to know about the underlying search algorithm to effectively use meta tools. The implementation details can change over time without affecting the user-facing API.
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes internal implementation details from the Meta Tools section in the README, making the documentation more user-focused and maintainable.
- Removed specific references to Orama and BM25 algorithm from the Meta Tools documentation
- Maintains focus on user-facing functionality (tool discovery and execution capabilities)
- Aligns with documentation best practices by avoiding implementation details that may change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Related: ENG-11260
NicolasBelissent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes implementation details (BM25 algorithm references) from the Meta Tools README section.
Users don't need to know about internal search algorithms to use meta tools effectively. This keeps the README focused on user-facing functionality and aligns with our documentation site.