test: add comprehensive TF-IDF index tests #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Expand TF-IDF test coverage from 3 to 16 tests, organized into logical test suites: 1. Core Functionality (3 tests - existing): - TF-IDF ranking with cosine similarity - Stopword and punctuation removal - No matches for non-overlapping queries 2. Score Validation (2 tests - new): - Scores within [0, 1] range - Results sorted by score descending 3. Edge Cases (4 tests - new): - Empty query handling - Empty corpus handling - Single document corpus - Query with only stopwords 4. Case Sensitivity (1 test - new): - Case-insensitive search across different cases 5. Tool Name Scenarios (3 tests - new): - Tool names with underscores - Multiple query terms - Action type ranking (create, list, etc) 6. Search Limits (2 tests - new): - Respects k parameter - Handles k > corpus size 7. IDF Calculation (1 test - new): - Rare terms get higher IDF scores These tests ensure the TF-IDF implementation is robust and handles real-world scenarios, especially tool discovery use cases. Matches test coverage added to Python SDK for feature parity.
ryoppippi
force-pushed
the
feat/improve-tfidf-tests
branch
from
ec954d5 to
2cbe5ec
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR significantly expands the test coverage for the TF-IDF index implementation by reorganizing existing tests into logical groups and adding comprehensive test cases for edge cases, score validation, case sensitivity, tool name scenarios, search limits, and IDF calculation behavior.
- Reorganized tests into structured
describeblocks for better organization - Added extensive test coverage for edge cases (empty queries/corpus, single document, stopword-only queries)
- Added tests for score validation, sorting, and range checking
- Added tests for case-insensitive search behavior
- Added practical tool name scenarios testing (relevant for the SDK's use case)
- Refactored CLAUDE.md to reference skill-based documentation
- Removed Orama docs MCP server configuration
- Added comprehensive skill documentation for testing, TypeScript patterns, file operations, and architecture
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/tfidf-index.spec.ts | Expanded test suite with 11 new test cases organized into 7 describe blocks covering edge cases, score validation, case sensitivity, tool name scenarios, search limits, and IDF calculation |
| CLAUDE.md | Refactored to delegate to skill-based documentation files for better organization and maintainability |
| .mcp.json | Removed Orama docs MCP server configuration |
| .claude/skills/typescript-testing/SKILL.md | Added comprehensive testing skill documentation covering Bun test runner, MSW patterns, and file system testing |
| .claude/skills/typescript-patterns/SKILL.md | Added TypeScript best practices skill covering exhaustiveness checking, avoiding any, and other patterns |
| .claude/skills/orama-integration/SKILL.md | Added Orama integration reference skill pointing to official documentation |
| .claude/skills/openapi-architecture/SKILL.md | Added architecture skill documenting core components and design patterns |
| .claude/skills/file-operations/SKILL.md | Added file operations skill documenting utility functions and HTTP standards |
| .claude/skills/development-workflow/SKILL.md | Added development workflow skill covering build commands, testing, and code quality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enrich tf-idf test