-
Notifications
You must be signed in to change notification settings - Fork 3
feat: make AI SDK and OpenAI SDK optional peer dependencies #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
19c0f09
feat: make AI SDK an optional peer dependency
ryoppippi 707f646
refactor: narrow try-catch scope to import only
ryoppippi 7466d5e
docs: add AI SDK optional installation instructions
ryoppippi 3faa207
fix: add await to toAISDK() calls in tests
ryoppippi 26af072
feat: make OpenAI SDK an optional peer dependency
ryoppippi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import * as orama from '@orama/orama'; | ||
| import { jsonSchema } from 'ai'; | ||
| import type { ChatCompletionTool } from 'openai/resources/chat/completions'; | ||
| import { RequestBuilder } from './modules/requestBuilder'; | ||
| import type { | ||
|
|
@@ -181,7 +180,7 @@ export class BaseTool { | |
| /** | ||
| * Convert the tool to AI SDK format | ||
| */ | ||
| toAISDK( | ||
| async toAISDK( | ||
| options: { executable?: boolean; execution?: ToolExecution | false } = { | ||
| executable: true, | ||
| } | ||
|
|
@@ -193,6 +192,17 @@ export class BaseTool { | |
| additionalProperties: false, | ||
| }; | ||
|
|
||
| /** AI SDK is optional dependency, import only when needed */ | ||
| let jsonSchema: typeof import('ai').jsonSchema; | ||
| try { | ||
| const ai = await import('ai'); | ||
| jsonSchema = ai.jsonSchema; | ||
| } catch { | ||
| throw new StackOneError( | ||
| 'AI SDK is not installed. Please install it with: npm install [email protected]|5.x or bun add [email protected]|5.x' | ||
| ); | ||
| } | ||
|
|
||
| const schemaObject = jsonSchema(schema); | ||
| const toolDefinition: Record<string, unknown> = { | ||
| inputSchema: schemaObject, // v5 | ||
|
|
@@ -346,14 +356,14 @@ export class Tools implements Iterable<BaseTool> { | |
| /** | ||
| * Convert all tools to AI SDK format | ||
| */ | ||
| toAISDK( | ||
| async toAISDK( | ||
| options: { executable?: boolean; execution?: ToolExecution | false } = { | ||
| executable: true, | ||
| } | ||
| ) { | ||
| const result: Record<string, unknown> = {}; | ||
| for (const tool of this.tools) { | ||
| Object.assign(result, tool.toAISDK(options)); | ||
| Object.assign(result, await tool.toAISDK(options)); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This catch block converts every import failure into "AI SDK is not installed", so real runtime errors inside the AI SDK (when it is installed) will be misreported and harder to debug. Please only wrap the missing-module case and rethrow other errors.
Prompt for AI agents
✅ Addressed in
ef5efc1