Cluster: Proactively reconfigure when we hit a MOVED response #2286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure about this because if there is a MOVED happening (e.g. bad proxy somewhere) this would just continually re-run...but only once every 5 seconds. Overall though, we linger in a bad state retrying moves until a discovery happens today and this could be resolved much faster. Meant to help address #1520, #1660, #2074, and #2020.
Making this speedy doesn't help if it's flaky in CI.
mgravell
approved these changes
Nov 8, 2022
Collaborator
mgravell
left a comment
mgravell
left a comment
There was a problem hiding this comment.
I'm fine with the hard-coded 5s as an initial; we can revisit based on feedback and knowledge in the future, if appropriate
This was
linked to
issues
Nov 15, 2022
….Redis into craver/moved-proactive
slorello89
approved these changes
Nov 15, 2022
Collaborator
slorello89
left a comment
slorello89
left a comment
There was a problem hiding this comment.
FWIW I started reviewing this a couple weeks ago and apparently forgot to submit it - had the same opinion as Marc - this should hopefully be niche enough that it doesn't come up too often, but I think 5 seconds is a perfectly reasonable default setting, and if needed we could always make it configurable in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to help address #1520, #1660, #2074, and #2020.
I'm not 100% sure about this because if there is a MOVED happening (e.g. bad proxy somewhere) this would just continually re-run...but only once every 5 seconds. Overall though, we linger in a bad state retrying moves until a discovery happens today and this could be resolved much faster.