Support LCS #2104
Merged
Support LCS #2104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
reviewed
Apr 28, 2022
Contributor
Author
|
@NickCraver Hey! |
Collaborator
|
@Avital-Fine, fixed the API declarations |
"Match" in .NET is usually RegEx match - let's remove some pain here and tidy up
Collaborator
|
@Avital-Fine I gave this some tidy love this morning, but gotta change gears a lot today. I think at the moment all this needs is more testing around missing key cases (1 or both) and non-matches. |
NickCraver
approved these changes
May 16, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Current looks good - thanks for iterating on this crazy command :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/commands/lcs/
#2055