Skip to content

Conversation

fank
Copy link
Contributor

@fank fank commented Jun 3, 2017

Relates #201

Example discord:

Before:
image

After:
image

@fank
Copy link
Contributor Author

fank commented Jun 3, 2017

Joining in discord current do not work, but that's an other issue i'm working on.

@fank
Copy link
Contributor Author

fank commented Jun 11, 2017

@vitalyster this is also ready to merge

@fank
Copy link
Contributor Author

fank commented Jun 11, 2017

rebased and green

@vitalyster
Copy link
Collaborator

This patch also contains "clean up" fixes and it makes me hard to understand it

@fank
Copy link
Contributor Author

fank commented Jun 11, 2017

split?

@vitalyster
Copy link
Collaborator

if these fixes still not in clean up patch - please add it into that one

@fank
Copy link
Contributor Author

fank commented Jun 11, 2017

@vitalyster i cant, because my editor will clean open files, and can't do that for the whole project.
But you can use the whitespace hide functionality https://github.com/blog/967-github-secrets

Add ?w=1 to the URL to see the diff with whitespace ignored.

@fank
Copy link
Contributor Author

fank commented Jun 11, 2017

i validated the cleanup changes is in #216

@fank
Copy link
Contributor Author

fank commented Jun 11, 2017

@vitalyster branch is now clean

@vitalyster
Copy link
Collaborator

Can you join these rooms now?

@fank
Copy link
Contributor Author

fank commented Jun 12, 2017

I havn't continued on the discord part jet, still not working.

@vitalyster
Copy link
Collaborator

So nothing to merge yet :)

@fank fank closed this Jun 19, 2017
@fank fank deleted the fk_multi_tree branch June 19, 2017 18:18
@fank fank restored the fk_multi_tree branch June 19, 2017 18:22
@fank fank reopened this Jun 19, 2017
@fank
Copy link
Contributor Author

fank commented Jun 19, 2017

i <3 automated scripts, entered wrong repo ... this should not be closed.

@fank fank closed this Nov 30, 2018
@vitalyster
Copy link
Collaborator

again???

@fank
Copy link
Contributor Author

fank commented Nov 30, 2018

Na i rechecked my PR's and noticed this is still open, but i ended all my xmpp related projects some month ago. so ill not continue this anymore.

@thundergreen
Copy link
Contributor

@fank NO GOOD NEWS!

@fank
Copy link
Contributor Author

fank commented Nov 30, 2018

Yea i know, but i'm still into developing stuff for discord so if someone would like to pick it up, than i could help. But i won't focus that.

@thundergreen
Copy link
Contributor

@fank did u ever hear about issue where either discord or spectrum send messages to muc when member leaves the channel? We tried to find the source of this message but could't find it. This makes channel use in xmpp impossible as muc will be flooded with leave messages

@vitalyster
Copy link
Collaborator

I hope references are stored in main repository, I will restore as new PRs for someone who will want to continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants