Skip to content

Improve DeFi UX #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

Improve DeFi UX #97

merged 1 commit into from
Jul 14, 2020

Conversation

JamesANZ
Copy link
Contributor

@JamesANZ JamesANZ commented Jul 14, 2020 •
edited
Loading

This PR:

  • adds a placeholder to let you know how much you can deposit and withdraw
  • Rounds down the numbers
  • Changes supply action name to deposit

TODO:

  • Check the borrow amount against the withdrawable and then show only what you can withdraw
  • Get the native balance in the card for cETH and other TokenScripts that depend on native balances

@JamesANZ JamesANZ requested review from SmartLayer and hboon July 14, 2020 02:58
@JamesANZ JamesANZ marked this pull request as ready for review July 14, 2020 02:58
hboon
hboon approved these changes Jul 14, 2020
View reviewed changes
@JamesANZ JamesANZ merged commit 73cf29d into master Jul 14, 2020
@JamesANZ JamesANZ deleted the improve-defi-ux branch July 14, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboon hboon hboon approved these changes

@SmartLayer SmartLayer Awaiting requested review from SmartLayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesANZ @hboon