Skip to content

Conversation

@fabinsch
Copy link
Collaborator

we have a first check in our helper function global_primal_residual_infeasibility that returns if a problem is supposed to be feasible.

I think the logic we want to check is

inf_norm(dy) == 0 AND infty_norm(dz) == 0

in this case, the problem is feasible.

However, we negate this statement as the output of the function is used to set the variable called is_primal_infeasible, here.

If we negate the statement above, and should be replaced by OR. The fix I propose here solves the issue in #327 and proxqp returns PROXQP_PRIMAL_INFEASIBLE as expected.

jcarpent
jcarpent previously approved these changes Jun 11, 2024
@jcarpent jcarpent enabled auto-merge June 11, 2024 08:35
@fabinsch fabinsch force-pushed the fix-infeas-detection branch 4 times, most recently from 2390f84 to 25cb5b3 Compare June 13, 2024 12:54
@jcarpent jcarpent force-pushed the fix-infeas-detection branch from 25cb5b3 to 45e59d2 Compare June 14, 2024 15:34
@jcarpent jcarpent disabled auto-merge June 15, 2024 07:54
@jcarpent jcarpent merged commit fe3a7ec into Simple-Robotics:devel Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants