Skip to content

Conversation

@andershagbard
Copy link
Contributor

@andershagbard andershagbard commented Aug 9, 2022

WHY are these changes introduced?

Resolves #161

Requiring psr/log@^1.1 is quite limiting. It wont even install on a fresh Laravel project for example.

WHAT is this pull request doing?

This PR adds a mock of Psr/Log/LoggerInterface, which is compatible version ^1, ^2 and ^3.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@andershagbard andershagbard requested a review from a team as a code owner August 9, 2022 15:56
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, this is great! Could you please rebase your branch so we can merge it?

@paulomarg paulomarg merged commit 58c6f86 into Shopify:main Aug 19, 2022
@andershagbard andershagbard deleted the psr-log-update branch August 19, 2022 13:18
@nam-co
Copy link

nam-co commented Sep 6, 2022

Hello, Im using Laravel 9 (php 8.1) but composer require shopify/shopify-api still produces the error:
shopify/shopify-api v3.1.0 requires psr/log ^1.1 -> found psr/log[1.1.0, ..., 1.1.4] but the package is fixed to 3.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

am I doing anything wrong? appreciate any help

@andershagbard
Copy link
Contributor Author

Hello, Im using Laravel 9 (php 8.1) but composer require shopify/shopify-api still produces the error: shopify/shopify-api v3.1.0 requires psr/log ^1.1 -> found psr/log[1.1.0, ..., 1.1.4] but the package is fixed to 3.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

am I doing anything wrong? appreciate any help

I don't think this is released yet. For a hotfix, you can require shopify/shopify-api@dev-main.

@fredden fredden mentioned this pull request Feb 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"psr/log": "^1.1",

3 participants