Reimplement RData on top of RTypedData #558
Draft
+142
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
rewrite-old-data
branch
3 times, most recently
from
556f462 to
5fabbe3
Compare
The goal is to eliminate `RTypedData.typed_flag` which waste `8B`, allowing `TypedData` to fit in a potential `32B` slot. This however makes `RData` 48B long, but given it's a deprecated construct it seems acceptable to degrade it to improve its replacement.
casperisfine
force-pushed
the
rewrite-old-data
branch
from
babf81c to
d166462
Compare
casperisfine
force-pushed
the
rewrite-old-data
branch
from
d166462 to
7a2ce88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to eliminate
RTypedData.typed_flagwhich waste 8B, allowingTypedDatato fit in a potential32Bslot.This however makes
RData48B long, but given it's a deprecated construct it seems acceptable to degrade it to improve its replacement.Paired with @etiennebarrie on it, it's mostly a proof of concept at this stage, needs ton of cleanup and does have some bugs.
FYI: @peterzhu2118 @eightbitraptor